Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: unify the terms NDV and cardinality in the optimizer (#26345) #26364

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 20, 2021

cherry-pick #26345 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26364

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26364:release-5.0-0bf495d5e856

What problem does this PR solve?

Issue Number: close #26283

Problem Summary: planner: unify the terms NDV and cardinality in the optimizer

What is changed and how it works?

In the optimizer, both terms NDV and cardinality are used to refer to the same meaning the number of distinct values.
In many other DBs, cardinality also means the estimated number of rows returned by a step or an operator.
So to make it clear and unified, we decided to remove cardinality and only use NDV to refer to this meaning in the optimizer.

No logical change, just rename some functions and variables.

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner July 20, 2021 04:01
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team July 20, 2021 04:01
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick labels Jul 20, 2021
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jul 20, 2021
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@qw4990
Copy link
Contributor

qw4990 commented Jul 20, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jul 20, 2021

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Jul 21, 2021

PTAL @zhouqiang-cl

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c06431

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit bbb1dbc into pingcap:release-5.0 Aug 30, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.3, v5.0.4 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants