Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: block the tiflash node for a period when it fails before. #26757

Merged
merged 5 commits into from
Aug 5, 2021
Merged

store/copr: block the tiflash node for a period when it fails before. #26757

merged 5 commits into from
Aug 5, 2021

Conversation

hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Jul 30, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary: When a tiflash down is down and recovered, it possibly cannot provide service for a period. If we send query to some unstable node, it will block the whole query.
To work around, we set a fail store ttl time. During that time, we will not send query to that node.

What is changed and how it works?

Proposal: See #26793

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

store/copr: block the tiflash node for a period when it fails before.

@hanfei1991 hanfei1991 requested a review from a team as a code owner July 30, 2021 09:47
@hanfei1991 hanfei1991 removed the request for review from a team July 30, 2021 09:47
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • zhouqiang-cl

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hanfei1991 hanfei1991 requested a review from winoros July 30, 2021 09:47
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 30, 2021
@hanfei1991
retry faster
664b37a 
add ttl for store fail time

set var

tiny fix

cancel retry

make retry time more accurate

fix tiny bug

fix bug

change default wait time
@hanfei1991 hanfei1991 requested a review from a team as a code owner August 2, 2021 09:22
@hanfei1991 hanfei1991 requested review from wshwsh12 and removed request for a team August 2, 2021 09:22
@windtalker
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the sig/execution SIG execution label Aug 2, 2021
@hanfei1991 hanfei1991 removed sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 4, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 4, 2021
@wshwsh12 wshwsh12 removed their request for review August 4, 2021 07:36
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2021
LittleFall
LittleFall approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall removed sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 4, 2021
LittleFall
LittleFall approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 4, 2021
zanmato1984
zanmato1984 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zanmato1984: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2021
zhouqiang-cl
zhouqiang-cl approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5af1143

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-chi-bot
Copy link
Member

@hanfei1991: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5991ba4 into pingcap:release-5.0 Aug 5, 2021
@hanfei1991 hanfei1991 deleted the hanfei/5.0-batch-retry branch August 6, 2021 06:01
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
This was referenced Sep 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@hanfei1991 @ti-chi-bot @windtalker @zhouqiang-cl @zanmato1984 @LittleFall