util/types: ignore string truncate error. #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
force-pushed
the
hanfei/bug
branch
from
02d1575 to
ec5a4ea
Compare
coocood
reviewed
Feb 20, 2017
| @@ -690,6 +690,11 @@ func (s *testSuite) TestIndexScan(c *C) { | |||
| tk.MustExec("CREATE INDEX idx_tab1_1 on tab1 (b, a)") | |||
| result = tk.MustQuery("SELECT pk FROM tab1 WHERE b > 1") | |||
| result.Check(testkit.Rows("3", "4")) | |||
|
|
|||
| tk.MustExec("drop table if exists t") | |||
| tk.MustExec("CREATE TABLE t (a varchar(3), index(a))") | |||
There was a problem hiding this comment.
insert t values ("aaa"), ("aab");
hanfei1991
force-pushed
the
hanfei/bug
branch
from
3e188dd to
6f47ac1
Compare
hanfei1991
force-pushed
the
hanfei/bug
branch
from
6f47ac1 to
23c890a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2653
create table t (a varchar(3), index (a));
insert t values ("aaaa") should report error.
select a < "aaaa" from t; shoud not report error.
@shenli @coocood @zimulala PTAL