Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the issue that UnionScan returns wrong results in dynamic mode #26876

Merged
merged 6 commits into from
Aug 4, 2021
Merged

planner: fix the issue that UnionScan returns wrong results in dynamic mode #26876

merged 6 commits into from
Aug 4, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 4, 2021

What problem does this PR solve?

Issue Number: close #26719

Problem Summary: planner: fix the issue that UnionScan returns wrong results in dynamic mode

What is changed and how it works?

planner: fix the issue that UnionScan returns wrong results in dynamic mode

Please see #26719 for more details.

Check List

Tests

  • Unit test

Release note 

planner: fix the issue that UnionScan returns wrong results in dynamic mode

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Aug 4, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-common-test

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-integration-test

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-common-test

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-integration-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-integration-tests tidb-test=pr/1146

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-integration-tests tidb-test=pr/1146

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-integration-tests tidb-test=pr/1146

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/run-integration-tests tidb-test=pr/1256

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a6fafb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@ti-chi-bot ti-chi-bot merged commit 4d5773c into pingcap:master Aug 4, 2021
This was referenced Aug 5, 2021
Closed
Closed
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 5, 2021

/run-cherry-picker

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 5, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 5, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26876 to release-5.0
81fa99c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26911

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 5, 2021

/cherry-pick release-5.1

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 5, 2021

/cherry-pick release-5.1

@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
1 task
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 5, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26876 to release-5.1
cbfd4e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26912

@Mini256 Mini256 mentioned this pull request Aug 7, 2021
Closed
@mjonss mjonss mentioned this pull request Nov 16, 2021
Closed
This was referenced Dec 7, 2021
Merged
Closed
@mjonss mjonss mentioned this pull request Dec 15, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@rebelice rebelice rebelice approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

union scan result error when using dynamic mode
6 participants
@qw4990 @ti-chi-bot @zhouqiang-cl @ti-srebot @rebelice @Reminiscent