Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate tableDual when partition pruning failed #26894

Merged
merged 10 commits into from
Aug 17, 2021
Merged

planner: generate tableDual when partition pruning failed #26894

merged 10 commits into from
Aug 17, 2021

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Aug 4, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #26551

Problem Summary:
When we prune the partition failed, it will report an error.

What is changed and how it works?

When we find an error after partition pruning, we should report a warning and generate tableDual.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2021
@Reminiscent
Copy link
Contributor Author

/label type/5.1-cherry-pick

@ti-chi-bot
Copy link
Member

@Reminiscent: The label(s) type/5.1-cherry-pick cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label type/5.1-cherry-pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Reminiscent
Copy link
Contributor Author

/label needs-cherry-pick-5.1

@ichn-hu ichn-hu mentioned this pull request Aug 4, 2021
Closed
@qw4990 qw4990 requested review from qw4990 and tiancaiamao August 12, 2021 02:26
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0c92cee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@Reminiscent
Copy link
Contributor Author

/merge

@Reminiscent
Copy link
Contributor Author

/rebuild

@Reminiscent
Copy link
Contributor Author

/release-note-none

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 17, 2021
@Reminiscent
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit d8c9c59 into pingcap:master Aug 17, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 17, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#26894 to release-5.1
e751a79 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27293

ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
planner: generate tableDual when partition pruning failed (#26894) (#…
f86eac8 
…27293)
@ChenPeng2013 ChenPeng2013 mentioned this pull request Sep 22, 2021
Closed
@Reminiscent Reminiscent deleted the issue#26551 branch February 7, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIGINT value is out of range
5 participants
@Reminiscent @ti-chi-bot @tiancaiamao @ti-srebot @qw4990