Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: generate tableDual when partition pruning failed #26894

Merged
merged 10 commits into from
Aug 17, 2021
Merged

planner: generate tableDual when partition pruning failed #26894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d22a19f
planner: generate tableDual when locate partition failed
Reminiscent Aug 4, 2021
e93e1d0
Merge branch 'master' of https://github.com/pingcap/tidb into issue#2…
Reminiscent Aug 4, 2021
0c92cee
Merge branch 'master' into issue#26551
qw4990 Aug 12, 2021
bdf8992
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
7a23090
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
6a61853
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
4fdf9b9
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
34a7005
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
2f9829c
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
8ab8fdf
Merge branch 'master' into issue#26551
ti-chi-bot Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions planner/core/partition_pruner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,3 +488,14 @@ func (s *testPartitionPruneSuit) TestRangePartitionPredicatePruner(c *C) {
tk.MustQuery(tt).Check(testkit.Rows(output[i].Result...))
}
}

func (s *testPartitionPruneSuit) TestIssue26551(c *C) {
tk := testkit.NewTestKit(c, s.store)
tk.MustExec("set @@tidb_partition_prune_mode='static'")
tk.MustExec("USE test;")
tk.MustExec("DROP TABLE IF EXISTS t;")
tk.MustExec("CREATE TABLE t (`COL1` int, `COL3` bigint) PARTITION BY HASH ((`COL1` * `COL3`))PARTITIONS 13;")
tk.MustQuery("explain format = 'brief' SELECT * FROM t WHERE col3 =2659937067964964513 and col1 = 783367513002;").Check(testkit.Rows(
"TableDual 0.00 root rows:0"))
tk.MustQuery("show warnings").Check(testkit.Rows("Warning 1690 BIGINT value is out of range in '(test.t.col1 * test.t.col3)'"))
}
3 changes: 2 additions & 1 deletion planner/core/rule_partition_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ func (s *partitionProcessor) processHashPartition(ds *DataSource, pi *model.Part
}
used, err := s.pruneHashPartition(ds.SCtx(), ds.table, ds.partitionNames, ds.allConds, ds.TblCols, names)
if err != nil {
return nil, err
// Just report warning and generate the tableDual
ds.SCtx().GetSessionVars().StmtCtx.AppendWarning(err)
}
if used != nil {
return s.makeUnionAllChildren(ds, pi, convertToRangeOr(used, pi))
Expand Down