Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Run errcheck and staticcheck via golangci-lint #26899

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 4, 2021

What problem does this PR solve?

Issue Number: #22979 (comment)

Problem Summary:

  • Run errcheck and staticcheck via golangci-lint
  • Cleanup gometalinter, gosec from Makefile
  • Move golangci-lint config to .golangci.yml
  • Add stylecheck and gosec to the golangci-lint config

Running everything under a single framework might speed up things and gives a more consistent result.

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Aug 4, 2021

/cc @disksing

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@disksing
Copy link
Contributor

disksing commented Aug 4, 2021

/cc @ngaut

@ti-chi-bot ti-chi-bot requested a review from ngaut August 4, 2021 12:58
@dveeden
Copy link
Contributor Author

dveeden commented Aug 4, 2021

I created 12e1617 (Draft PR: #26907) to remove some gosec excludes and use annotations instead and/or fix the issues gosec found.

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2021
@disksing
Copy link
Contributor

disksing commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: edcbcdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-chi-bot
Copy link
Member

@dveeden: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 019fab3 into pingcap:master Aug 5, 2021
guo-shaoge added a commit to guo-shaoge/tidb that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants