Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ddl: fix create partition table error under NO_UNSIGNED_SUBTRACTION" #26935

Merged
merged 7 commits into from
Aug 10, 2021
Merged

Revert "ddl: fix create partition table error under NO_UNSIGNED_SUBTRACTION" #26935

merged 7 commits into from
Aug 10, 2021

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Aug 5, 2021 •
edited
Loading

Reverts #25435

What problem does this PR solve?

Problem Summary:

the PR introduces a bug #26765, it fixes a corner case but breaks a more common case. I am gonna revert PR #25435 and document the bad case in the issues #24880. see #25437 (comment) for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

fix a bug that creates partition fail if `NO_UNSIGNED_SUBTRACTION` is set.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2021
@xiongjiwei xiongjiwei marked this pull request as draft August 5, 2021 10:56
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2021
@xiongjiwei xiongjiwei marked this pull request as ready for review August 5, 2021 11:20
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 5, 2021
mjonss
mjonss approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM (but I'm not yet an approver). But I would suggest you to add an additional cleanup after creating the table in the test.

table/tables/partition_test.go Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@mjonss: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/LGTM (but I'm not yet an approver). But I would suggest you to add an additional cleanup after creating the table in the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a07af9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2021
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit bb32631 into master Aug 10, 2021
@ti-chi-bot ti-chi-bot deleted the revert-25435-partitionFix1 branch August 10, 2021 04:09
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 10, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#26935 to release-5.1
38e810a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 10, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27053

@xiongjiwei
Copy link
Contributor Author

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Aug 11, 2021
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 11, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#26935 to release-5.2
8536901 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27100

ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
Revert "ddl: fix create partition table error under NO_UNSIGNED_SUBTR…
14d2c0a 
…ACTION" (#26935) (#27053)
ti-chi-bot pushed a commit that referenced this pull request Oct 12, 2021
@ti-srebot
Revert "ddl: fix create partition table error under NO_UNSIGNED_SUBTR…
5db6f20 
…ACTION" (#26935) (#27100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xiongjiwei @ti-chi-bot @bb7133 @xhebox @ti-srebot @mjonss