session, variable: cleanup TiDBEvolvePlanBaselines sysvar validation #27004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
This is a cleanup following #26333
What is changed and how it works?
What's Changed:
In the PR #26333 validation for the sysvar was performed in the functions
SetGlobalSysVar
andSetSessionFromHook
. But the API for sysvars allows for a validation function to be specified in the sysvar struct. Handling it this way is preferred because then plugins have access to exactly the same API. It also keeps the sysvar handling centralized and consistent.Check List
Tests
Side effects
Documentation
Release note