Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, variable: cleanup TiDBEvolvePlanBaselines sysvar validation #27004

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 9, 2021

What problem does this PR solve?

Problem Summary:

This is a cleanup following #26333

What is changed and how it works?

What's Changed:

In the PR #26333 validation for the sysvar was performed in the functions SetGlobalSysVar and SetSessionFromHook. But the API for sysvars allows for a validation function to be specified in the sysvar struct. Handling it this way is preferred because then plugins have access to exactly the same API. It also keeps the sysvar handling centralized and consistent.

Check List

Tests

  • Unit test (covered by existing tests)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@morgo morgo requested review from Reminiscent and a team August 9, 2021 02:04
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15c6541

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 9, 2021
@ti-chi-bot ti-chi-bot merged commit 83ebdf3 into pingcap:master Aug 9, 2021
@Reminiscent
Copy link
Contributor

Good catch! Thanks for your contribution. @morgo

@morgo morgo deleted the cleanup-evolve-baselines-sysvar branch August 9, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants