-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Fix the problem that PlanBuilder.buildWindowFunctions
may change sub operator's schema.
#27176
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
[2021-08-12T20:04:28.602Z] cd tools/check; \ [2021-08-12T20:04:28.602Z] GO111MODULE=on go build -o ../bin/failpoint-ctl github.com/pingcap/failpoint/failpoint-ctl [2021-08-12T20:04:33.881Z] /bin/sh: Rewrite: command not found [2021-08-12T20:04:33.881Z] make: *** [failpoint-enable] Error 127 |
/run-check_dev_2 |
[2021-08-13T06:22:47.994Z] FAIL [2021-08-13T06:22:47.994Z] + cat test.log [2021-08-13T06:22:47.994Z] + grep -Ev '^[[[:digit:]]{4}(/[[:digit:]]{2}){2}' [2021-08-13T06:22:47.994Z] + grep -A 30 '-------' [2021-08-13T06:22:47.994Z] + grep -A 29 '^FAIL:' [2021-08-13T06:22:47.994Z] FAIL: ddl_test.go:1302: testSuite6.TestSetDDLErrorCountLimit [2021-08-13T06:22:47.994Z] [2021-08-13T06:22:47.994Z] ddl_test.go:1324: [2021-08-13T06:22:47.994Z] c.Assert(variable.GetDDLErrorCountLimit(), Equals, int64(100)) [2021-08-13T06:22:47.994Z] ... obtained int64 = 512 [2021-08-13T06:22:47.994Z] ... expected int64 = 100 |
/run_check_dev_2 |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bd9716f
|
[2021-08-13T07:43:16.286Z] + grep -A 29 '^FAIL:' [2021-08-13T07:43:16.286Z] FAIL: infoschema_reader_test.go:561: testInfoschemaTableSuite.TestForAnalyzeStatus [2021-08-13T07:43:16.286Z] [2021-08-13T07:43:16.286Z] infoschema_reader_test.go:595: [2021-08-13T07:43:16.286Z] c.Assert(len(resultT1.Rows()), Greater, 0) [2021-08-13T07:43:16.286Z] ... compare_one int = 0 [2021-08-13T07:43:16.286Z] ... compare_two int = 0 [2021-08-13T07:43:16.286Z] [2021-08-13T07:43:16.286Z] PASS: write_test.go:2076: testSuite4.TestIssue18681 0.034s [2021-08-13T07:43:16.286Z] PASS: adm |
/run_check_dev_2 |
/merge |
/run-all-tests |
/merge |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #27201 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #27202 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #27203 |
…change sub operator's schema. (pingcap#27176)
/run-cherry-picker |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #27204 |
…change sub operator's schema. (pingcap#27176) (pingcap#27201)
What problem does this PR solve?
Issue Number: close #27148
Problem Summary:
buildWindowFunctions
will use sub operator's schema as itself's, for example, hereobtains the sub operator's schema, and then changed them here
This may cause some unexpected behaviors, for example in mpp query, making the schema of exchangeReceiver and exchangeSender not equal and then throw errors as the issue said.
for example, it will build a plan like:
the (3,1), (25,1), (47,1) means output schema's attribute
flen
anddecimal
intypeDecimal
, but the excepted isWhat is changed and how it works?
Proposal: xxx
What's Changed: let it obtain a column's clone.
Are there any suggestions for fixing it better?
Check List
Tests
Release note