Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: less split during restoring #27240

Merged
merged 18 commits into from
Sep 1, 2021
Merged

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 16, 2021

Port of pingcap/br#1377

What problem does this PR solve?

Partially fix pingcap/br#1374

What is changed and how it works?

before:
--|-------t1 data-------|-----|---t2 data-------|
after: 
----------t1 data-------|---------t2 data-------|

Legends:
'|' the split point
'-' the key space

Also, downloadSST would find rewrite rules by file instead of region start key for now.

Check List

Tests

image

Release note

BR would split less regions to reduce the number of empty region after restoration.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@YuJuncen
Copy link
Contributor Author

/sig migrate
/component br

@ti-chi-bot ti-chi-bot added sig/migrate component/br This issue is related to BR of TiDB. labels Aug 16, 2021
@YuJuncen
Copy link
Contributor Author

/hold because the random download file skipped warnings. (Even didn't made data lost)

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@YuJuncen
Copy link
Contributor Author

/unhold because:

  1. The download file skipped only happens in v4.x, and current release-4.0 has the same problem.
  2. The probability of scattering no-empty region could be omitted via one less scatter.

@YuJuncen
Copy link
Contributor Author

/remove-hold
🤔

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
br/pkg/restore/import.go Outdated Show resolved Hide resolved
Co-authored-by: kennytm <kennytm@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2021
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2dad755

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@ti-chi-bot
Copy link
Member

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/migrate size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many empty region after restoration of many small tables
4 participants