*: Audit plugin should handle errors and stmt start

[morgo]

What problem does this PR solve?

Issue Number: close #27268

Problem Summary:

The plugin API looks like it was intended to have multiple GeneralEvent types, but currently only the Log type is used. Log itself is ambiguous because it doesn't say if this means the event is complete, or is about to start. I thought it would be OK to rename, since it is already going to break the existing audit plugin by the next change, which is that the OnGeneralEvent will be called both before and after the statement executes. It will also be called on statement (dispatch) error.

What is changed and how it works?

What's Changed:

The audit plugin API can now log before statements start execution or result in errors.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility (API compatibility)

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

The audit plugin API can now log before statements start execution or result in errors.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lysu
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

[morgo]

/run-check_title

[gregwebs]

It's almost always better to make a change backwards compatible. Doubly so for plugins. I think in this case a newer version of a plugin can either implement OnGeneralEvent2 or register as a v2 plugin.
For older plugins I think an adapter can be implemented to downgrade the new version to the previous version.

[morgo]

@djshow832 This has the Starting event after parse, but in #27268 you commented that it should be before parse. I don't have strong opinions, but in case you do.. I've added you as a reviewer.

[xiongjiwei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 28a33e2

[ti-chi-bot]

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.