ddl: forbidden flashback/recover local temprorary table #27323
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
| @@ -821,7 +821,7 @@ func (e *DDLExec) getRecoverTableByTableName(tableName *ast.TableName) (*model.J | |||
| return nil, nil, err | |||
| } | |||
| if tableInfo == nil || jobInfo == nil { | |||
| return nil, nil, errors.Errorf("Can't find dropped/truncated table: %v in DDL history jobs", tableName.Name) | |||
| return nil, nil, errors.Errorf("Can't find localTemporary/dropped/truncated table: %v in DDL history jobs", tableName.Name) | |||
There was a problem hiding this comment.
I don't think this modification is necessary. It may mislead users that local temporary table should be found in ddl history jobs but not.
There was a problem hiding this comment.
The point is we can not distinguish a dropped local temporary table from a non-existent table if we do not cache the dropped localTemporary.
Only in DDL history jobs that we can flashback/recover a table, local temporary is not in the jobs, so it can not be flashback/recover. I think the user doesn't care about if it shoud be.
There was a problem hiding this comment.
Emm.. My opinion is that we should clarify our behavior that local temporary table will not be recovered if it is dropped. These error message may make user think that "local temporary should be found in ddl history jobs but not" and may regard it as bug. Just a personal opinion...
There was a problem hiding this comment.
I think it's fine to remove this part and just report errUnsupportedFlashbackTmpTable just like global temporary tables. The behavior is consistent and easy to understand: we just don't support that.
| @@ -821,7 +821,7 @@ func (e *DDLExec) getRecoverTableByTableName(tableName *ast.TableName) (*model.J | |||
| return nil, nil, err | |||
| } | |||
| if tableInfo == nil || jobInfo == nil { | |||
| return nil, nil, errors.Errorf("Can't find dropped/truncated table: %v in DDL history jobs", tableName.Name) | |||
| return nil, nil, errors.Errorf("Can't find localTemporary/dropped/truncated table: %v in DDL history jobs", tableName.Name) | |||
There was a problem hiding this comment.
I think it's fine to remove this part and just report errUnsupportedFlashbackTmpTable just like global temporary tables. The behavior is consistent and easy to understand: we just don't support that.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 62de085
|
ti-chi-bot
added
the
status/can-merge
|
@sylzd: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #25940
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Modify the error info, because we can not distinguish the dropped local temporary table from a non-existent table.
How it Works:
Check List
Tests
Side effects
Documentation
Release note