Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, expression: avoid exprs with side effects in column pruning and agg pushdown #27370

Merged
merged 6 commits into from
Aug 27, 2021
Merged

planner, expression: avoid exprs with side effects in column pruning and agg pushdown #27370

merged 6 commits into from
Aug 27, 2021

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Aug 19, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #27106

Problem Summary:

What is changed and how it works?

  1. Do not prune expressions with side effects in column pruning. (planner/core/rule_column_pruning.go)
  2. Do not push down agg across projection if there are expressions with side effects in projection. (planner/core/rule_aggregation_push_down.go)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2021
@time-and-fate time-and-fate marked this pull request as draft August 19, 2021 05:51
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2021
@time-and-fate time-and-fate force-pushed the issue27093 branch 2 times, most recently from 71b5039 to 2cf0169 Compare August 24, 2021 03:26
@time-and-fate
Copy link
Member Author

/run-common-test

@time-and-fate
Copy link
Member Author

/run-integrated-common-test

@time-and-fate time-and-fate changed the title planner: WIP planner, expression: avoid exprs with side effects in column pruning and agg pushdown Aug 24, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 24, 2021
@time-and-fate
Copy link
Member Author

/run-common-test

@time-and-fate
Copy link
Member Author

/run-sqllogic-test

@time-and-fate
Copy link
Member Author

/run-sqllogic-test
/run-integration-compatibility-test
/run-integration-copr-test
/run-integration-ddl-test
/run-mybatis-test
/run-plugin-test
/run-tics-test

@time-and-fate
Copy link
Member Author

/run-integration-compatibility-test

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2021
@time-and-fate
Copy link
Member Author

/run-check_dev_2
/run-sqllogic-test
/run-integration-compatibility-test
/run-integration-copr-test
/run-integration-ddl-test
/run-mybatis-test
/run-plugin-test
/run-tics-test

@time-and-fate time-and-fate mentioned this pull request Aug 26, 2021
Closed
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2021
@winoros
Copy link
Member

winoros commented Aug 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b8f56ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@ti-chi-bot ti-chi-bot merged commit 8dcebd1 into pingcap:master Aug 27, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#27370 to release-4.0
b2d8a32 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27636

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#27370 to release-5.0
db0c6e9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27637

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#27370 to release-5.1
3dc05ee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27638

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#27370 to release-5.2
82a640f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27639

ti-chi-bot pushed a commit that referenced this pull request Sep 3, 2021
@ti-srebot
planner, expression: avoid exprs with side effects in column pruning …
8ca7563 
…and agg pushdown (#27370) (#27637)
ti-chi-bot pushed a commit that referenced this pull request Sep 15, 2021
@ti-srebot
planner, expression: avoid exprs with side effects in column pruning …
b71e74a 
…and agg pushdown (#27370) (#27638)
ti-chi-bot pushed a commit that referenced this pull request Oct 15, 2021
@ti-srebot
planner, expression: avoid exprs with side effects in column pruning …
d20a8b5 
…and agg pushdown (#27370) (#27639)
This was referenced Oct 25, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong query result when session variable is used as group by item
5 participants
@time-and-fate @ti-chi-bot @winoros @ti-srebot @Reminiscent