Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: update max backoff. #2746

Merged
merged 4 commits into from
Mar 1, 2017
Merged

store/tikv: update max backoff. #2746

merged 4 commits into from
Mar 1, 2017

Conversation

disksing
Copy link
Contributor

Based on the current tikv-server configuration, the leader election could last for more than 10 seconds. Therefore, max backoff need to be adjusted.

PTAL @coocood

@coocood
Copy link
Member

coocood commented Feb 27, 2017

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

LGTM

@siddontang
Copy link
Member

should use a smaller value.

@disksing
Copy link
Contributor Author

PTAL @coocood @tiancaiamao @siddontang

@coocood
Copy link
Member

coocood commented Feb 28, 2017

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@disksing disksing merged commit a2a35c1 into master Mar 1, 2017
@disksing disksing deleted the disksing/max-backoff branch March 1, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@disksing @coocood @tiancaiamao @siddontang @zimulala @shenli