*: Implementing information_schema.placement_rules #27478

mjonss · 2021-08-23T03:08:40Z

What problem does this PR solve?

Issue Number: partly close #26681, still missing Direct placement for Partitions (not yet implemented)

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

information_schema.placement_rules lists all defined PLACEMENT POLICY and Tables with Direct Placement rules

But not filling it with correct data and columns are still not fully defined.

ti-chi-bot · 2021-08-23T03:08:42Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

morgo
xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: ailinkid <314806019@qq.com>

…into is.placement_rules

TODO: Schema level TODO: Partition level TODO: Add tests for privileges on Schema and Table level

djshow832 · 2021-09-16T08:44:45Z

executor/infoschema_reader.go

+					}
+				}
+			} */
+			if table.DirectPlacementOpts == nil {


Do we need to output the relationship between named placement policies and tables?

I think that is what the SHOW PLACEMENT [FOR ...] is for. As I understand the requirements for information_schema.placement_rules is to find all definitions of placement rules, not necessary which objects are using the named policies. But I also don't know how you would get the full list of objects using a specific PLACEMENT POLICY.

That's right - my intention in the proposal was to include those that have policies.

and some minor cleanup

xhebox

Rest LGTM

xhebox · 2021-09-27T01:59:56Z

executor/infoschema_reader.go

+	// Get global PLACEMENT POLICIES
+	// Currently no privileges needed for seeing global PLACEMENT POLICIES!


Whatever, the PR looks good to me. Maybe should merge it first.

For the problem, I think a new dynamic priv is enough. I could argue that there will be only one super DBA responsible for placement configurations, because only if you know all clusters can you schedule it better.

The problem only happens when there are two sets of settings, e.g. one in cn and another in us... But I think it can be effectively filtered using tricks like name: cn_policy_1.

xhebox

I guess it is prepared since partition support is added.

morgo · 2021-10-15T00:39:01Z

/merge

ti-chi-bot · 2021-10-15T00:39:05Z

This pull request has been accepted and is ready to merge.

Commit hash: a491ae5

ti-chi-bot · 2021-10-15T00:39:16Z

@mjonss: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

First commit, just creating the information_schema.placement_rules

45f8d0d

But not filling it with correct data and columns are still not fully defined.

github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 23, 2021

mjonss and others added 12 commits August 23, 2021 17:34

Merge branch 'pingcap:master' into is.placement_rules

3aea163

support create and drop placement policy

9e61c9f

Signed-off-by: ailinkid <314806019@qq.com>

clean code

7694a70

Signed-off-by: ailinkid <314806019@qq.com>

fmt

927ed78

Signed-off-by: ailinkid <314806019@qq.com>

lint

2c213c0

Signed-off-by: ailinkid <314806019@qq.com>

Merge branch 'master' into create-drop-placement-policy

f856dc1

.

5109c46

Signed-off-by: ailinkid <314806019@qq.com>

make errdoc

602d158

Signed-off-by: ailinkid <314806019@qq.com>

Temporary commit for investigating placement rules

b3bd97d

Merge remote-tracking branch 'AilinKid/create-drop-placement-policy' …

9b55810

…into is.placement_rules

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

cd17f7e

added information_schema.placement_rules for PLACEMENT POLICY

26ff1f8

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2021

mjonss and others added 2 commits September 8, 2021 17:32

Merge branch 'master' into is.placement_rules

f946946

add direct placement for tables into information_schema.placement_rules

54b5fff

TODO: Schema level TODO: Partition level TODO: Add tests for privileges on Schema and Table level

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2021

mjonss mentioned this pull request Sep 8, 2021

Support information_schema.placement_rules #26681

Closed

mjonss added 3 commits September 9, 2021 14:28

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

2f5832c

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

397d51b

add privilege test for is.placement_rules and some cleanup

de9110d

mjonss marked this pull request as ready for review September 13, 2021 22:37

djshow832 reviewed Sep 16, 2021

View reviewed changes

mjonss and others added 4 commits September 16, 2021 12:32

removed VOTERS and VOTER_CONSTRAINTS from is.placement_rules

b563bf2

and some minor cleanup

updated test results after removing VOTER_CONSTRAINTS and VOTERS

334bc68

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

4ec2b45

Merge branch 'master' into is.placement_rules

9bbe14b

xhebox self-requested a review September 22, 2021 08:06

morgo self-requested a review September 22, 2021 22:47

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2021

mjonss added 3 commits September 23, 2021 23:56

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

7ed7ca0

Updated comment according to reviewer (Direct Placement extraction)

90a474a

added schema direct placement to is.placement_rules

92fac7f

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 23, 2021

xhebox reviewed Sep 27, 2021

View reviewed changes

Merge remote-tracking branch 'pingcap/master' into is.placement_rules

742a5f7

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2021

Added partitions in information_schema.placement_rules

a491ae5

xhebox approved these changes Oct 13, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2021

morgo approved these changes Oct 15, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 15, 2021

Merge branch 'master' into is.placement_rules

5918f92

ti-chi-bot merged commit 81c3013 into pingcap:master Oct 15, 2021

sylzd mentioned this pull request Nov 25, 2021

dumpling: Add support for Create Placement #29724

Merged

12 tasks

mjonss deleted the is.placement_rules branch March 3, 2022 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Implementing information_schema.placement_rules #27478

*: Implementing information_schema.placement_rules #27478

mjonss commented Aug 23, 2021 •

edited

Loading

ti-chi-bot commented Aug 23, 2021 •

edited

Loading

djshow832 Sep 16, 2021

mjonss Sep 16, 2021

morgo Sep 22, 2021

xhebox left a comment

xhebox Sep 27, 2021

xhebox left a comment

morgo commented Oct 15, 2021

ti-chi-bot commented Oct 15, 2021

ti-chi-bot commented Oct 15, 2021

		// Get global PLACEMENT POLICIES
		// Currently no privileges needed for seeing global PLACEMENT POLICIES!

*: Implementing information_schema.placement_rules #27478

*: Implementing information_schema.placement_rules #27478

Conversation

mjonss commented Aug 23, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 23, 2021 • edited Loading

djshow832 Sep 16, 2021

Choose a reason for hiding this comment

mjonss Sep 16, 2021

Choose a reason for hiding this comment

morgo Sep 22, 2021

Choose a reason for hiding this comment

xhebox left a comment

Choose a reason for hiding this comment

xhebox Sep 27, 2021

Choose a reason for hiding this comment

xhebox left a comment

Choose a reason for hiding this comment

morgo commented Oct 15, 2021

ti-chi-bot commented Oct 15, 2021

ti-chi-bot commented Oct 15, 2021

mjonss commented Aug 23, 2021 •

edited

Loading

ti-chi-bot commented Aug 23, 2021 •

edited

Loading