-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: enhance the extract table from update/insert/delete stmt in binding sql check #27519
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@sylzd This seems to be a planner pr instead of ddl, I have modified the title for you |
@lcwangchao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5369b4e
|
What problem does this PR solve?
Issue Number: close #27442
Problem Summary:
extractTablelist used to checking simple sql before. the enhancement makes it get the table list from complicated sql.
What is changed and how it works?
Proposal: xxx
What's Changed:
extracTableList
func modified.How it Works:
Check List
Tests
Side effects
Maybe some Side effects when extracTableList used other places.
Documentation
Release note