Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: Add RangedKVRetriever struct to provide custom range data operations #27543

Merged
merged 8 commits into from
Aug 25, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #27541

Problem Summary:

see #26952

To make a better implement for temporary table. It is required that snapshot can read data from other sources like memory for some specified ranges. So we expect snapshot can provide some methods to override data fetch.

What is changed and how it works?

draft is here tikv/client-go#262 . Because it is not a universal demand, so move it to tidb。

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2021
@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 24, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@tiancaiamao
Copy link
Contributor

I'll take a look tomorrow

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2021
Co-authored-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member

@disksing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@disksing
Copy link
Contributor

/rebuild

@lcwangchao lcwangchao added the sig/transaction SIG:Transaction label Aug 25, 2021
@disksing
Copy link
Contributor

/approve

@disksing
Copy link
Contributor

LGTM

@disksing
Copy link
Contributor

/lgtm

@lcwangchao lcwangchao requested a review from disksing August 25, 2021 07:56
@lcwangchao lcwangchao requested a review from disksing August 25, 2021 07:56
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2021
@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 343560b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@ti-chi-bot ti-chi-bot merged commit 0f459ef into pingcap:master Aug 25, 2021
@lcwangchao lcwangchao deleted the ranged_kv_retriever branch October 18, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
4 participants