ddl: support create and drop placement policy #27574
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
|
/run-all-tests |
github-actions
bot
added
sig/execution
| return err | ||
| } | ||
| // Auto fill the policyID when it is inserted. | ||
| policyInfo, err := buildPolicyInfo(stmt) |
There was a problem hiding this comment.
I think we should do some checks here.
There was a problem hiding this comment.
this work is remained as described above into next pull request. otherwise, this is a too huge pr
ti-chi-bot
added
the
needs-rebase
Signed-off-by: ailinkid <314806019@qq.com>
Signed-off-by: ailinkid <314806019@qq.com>
AilinKid
force-pushed
the
create-drop-placement-policy
branch
from
922f38d to
2c213c0
Compare
ti-chi-bot
removed
the
needs-rebase
Signed-off-by: ailinkid <314806019@qq.com>
Signed-off-by: ailinkid <314806019@qq.com>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5a3764e
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: part of #26580
What is changed and how it works?
Proposal: placement policy
What's Changed:
Support create placement policy and drop placement policy basically.
What's Remained:
1: create policy and drop policy statement privilege check
2: create policy should have the constraint yaml format check
3: create policy should have the constraint compatibility check
4: drop policy should have the clean the policy dependency in it's usage.
5: drop policy should notify the pd about the db/table/partition's schedule change.
Check List
Tests
Release note