-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: validate the placement policy constraint when create it #27668
ddl: validate the placement policy constraint when create it #27668
Conversation
Signed-off-by: ailinkid <314806019@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1783fb1
|
@AilinKid: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: partial close #26580
What is changed and how it works?
What's Changed:
when
create placement policy name ???_constraints=string, constraints=string
, the common constraints is actually appended to the previous constraints. This way, we will check the compatibility for the merge of them.Check List
Tests
Documentation
Release note