Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support ALTER PLACEMENT POLICY ... #27733

Merged
merged 10 commits into from
Sep 5, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #27714

Check List

Tests

  • Unit test

Release note

ddl: support `ALTER PLACEMENT POLICY ...`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2021
@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Sep 1, 2021
@morgo
Copy link
Contributor

morgo commented Sep 1, 2021

LGTM, but I don't know ddl well. I will leave for others to approve.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ddl/placement_policy.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2021
@AilinKid
Copy link
Contributor

AilinKid commented Sep 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5ec9072

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@AilinKid
Copy link
Contributor

AilinKid commented Sep 3, 2021

/run-check_dev_2

[2021-09-03T09:16:22.657Z] placement_policy_test.go:222:

[2021-09-03T09:16:22.657Z] c.Assert(err.Error(), Equals, ca.errmsg)

[2021-09-03T09:16:22.657Z] ... obtained string = "" +

[2021-09-03T09:16:22.657Z] ... "invalid label constraints format: should be [constraint1, ...] (error yaml: unmarshal errors:\n" +

[2021-09-03T09:16:22.657Z] ... " line 1: cannot unmarshal !!map into []string)"

[2021-09-03T09:16:22.657Z] ... expected string = "" +

[2021-09-03T09:16:22.657Z] ... "[ddl:-1]invalid label constraints format: should be [constraint1, ...] (error yaml: unmarshal errors:\n"

[2021-09-03T09:16:22.657Z] ... " line 1: cannot unmarshal !!map into []string)"

@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2021
@AilinKid
Copy link
Contributor

AilinKid commented Sep 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a7b185a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 5, 2021
@ti-chi-bot ti-chi-bot merged commit 6805e34 into pingcap:master Sep 5, 2021
@lcwangchao lcwangchao deleted the placement_policy_alter branch September 5, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ALTER PLACEMENT POLICY
5 participants