executor: range task channel in XSelectIndexExec.Close. #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shenli @tiancaiamao PTAL |
shenli
reviewed
Mar 4, 2017
| @@ -505,11 +517,6 @@ func (e *XSelectIndexExec) nextForDoubleRead() (*Row, error) { | |||
| } | |||
| row, err := e.taskCurr.getRow() | |||
| if err != nil { | |||
| // Consume the task channel in case channel is full. | |||
There was a problem hiding this comment.
It is moved to Close method.
shenli
reviewed
Mar 5, 2017
| // leak. For testing distsql with multiple regions, we need to manually split a mock TiKV. | ||
| func (s *testSuite) TestIndexDoubleReadClose(c *C) { | ||
| if _, ok := s.store.GetClient().(*tikv.CopClient); !ok { | ||
| // Make sure the store is tikv store. |
There was a problem hiding this comment.
Should we assert ok is True here? Or the test case may be ignored.
There was a problem hiding this comment.
The test can be configured to run with localstore, then the client is not *tikv.CopClient.
|
LGTM |
|
@tiancaiamao @zimulala PTAL |
|
LGTM |
zimulala
approved these changes
Mar 6, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes goroutine leak.