Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong plan caused by shallow copy schema columns #27798

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Sep 3, 2021

What problem does this PR solve?

Issue Number: close #27797 close #26554

Problem Summary:
In agg push down, we make the schema of the Union and the first child of the Union(a DataSource in the case) share the same array.
Then in the column pruning, when we are pruning columns of the child of the Union, the schema of Union is also changed because they share the same slice.

What is changed and how it works?

Deep copy schema columns when push agg across Union.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2021
@time-and-fate
Copy link
Member Author

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Sep 3, 2021
@time-and-fate
Copy link
Member Author

/run-check_dev_2

@time-and-fate
Copy link
Member Author

/run-sqllogic-test
/run-integration-compatibility-test
/run-integration-copr-test
/run-integration-ddl-test
/run-mybatis-test
/run-plugin-test
/run-tics-test

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also add the test case in #26554 and close it.

... And we need cherry-pick this pr to 4.0, 5.0, 5.1, 5.2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-
/label needs-cherry-pick-

@ti-chi-bot
Copy link
Member

@time-and-fate: The label(s) needs-cherry-pick-, needs-cherry-pick- cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label needs-cherry-pick-
/label needs-cherry-pick-

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.2

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 918cb53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot ti-chi-bot merged commit 68e32bb into pingcap:master Sep 6, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27836

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27837

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27838

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong result when aggregation on partition table Internal error: UnionExec chunk column count mismatch
5 participants