Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: decrease the execution time of TestMockVecPlusIntParallel #27944

Merged
merged 6 commits into from
Sep 10, 2021

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Sep 10, 2021

What problem does this PR solve?

Issue Number: close #27446

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Reduced number of cycles of TestMockVecPlusIntParallel

How it Works:
Before this commit:

PASS: builtin_vectorized_test.go:119: testVectorizeSuite2.TestMockVecPlusIntParallel    0.731s

After this commit:

PASS: builtin_vectorized_test.go:120: testVectorizeSuite2.TestMockVecPlusIntParallel    0.004s

Check List

Tests

Side effects

Documentation

Release note

None

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. component/test component/expression sig/execution SIG execution labels Sep 10, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@XuHuaiyu XuHuaiyu changed the title expression: increase the execution time of TestMockVecPlusIntParallel expression: decrease the execution time of TestMockVecPlusIntParallel Sep 10, 2021
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2021
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 862ebe9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2021
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@XuHuaiyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit aa04be3 into pingcap:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/test release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable test builtin_vectorized_test.go:119: testVectorizeSuite2.TestMockVecPlusIntParallel
4 participants