-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx/variable: fix incorrect parallel tests #27981
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@tisonkun: Adding label: Reasons for blocking this PR:[This PR modifies significant config files which require review from domain experts. /cc qw4990 bb7133 XuHuaiyu cfzjywxk morgo Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @xiongjiwei PTAL for following up #27848 (comment) |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2526007
|
@cfzjywxk I just learn that you should remove "do-not-merge" label manually to proceed the PR. |
/merge |
@tisonkun: Adding label: Reasons for blocking this PR:[This PR modifies significant config files which require review from domain experts. /cc qw4990 bb7133 XuHuaiyu cfzjywxk morgo Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tisonkun: Illegal modification of do-not-merge/blocked-paths label. In response to removing label named do-not-merge/blocked-paths. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
/merge |
@tisonkun: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
What problem does this PR solve?
Issue Number: close #27979
Problem Summary: details in the issue.
Release note