Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: fix incorrect parallel tests #27981

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

tisonkun
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27979

Problem Summary: details in the issue.

Release note

None

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/blocked-paths labels Sep 13, 2021
@ti-chi-bot
Copy link
Member

@tisonkun: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies significant config files which require review from domain experts.

/cc qw4990 bb7133 XuHuaiyu cfzjywxk morgo
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2021
@tisonkun
Copy link
Contributor Author

/cc @xiongjiwei

PTAL for following up #27848 (comment)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2526007

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2021
@tisonkun
Copy link
Contributor Author

@cfzjywxk I just learn that you should remove "do-not-merge" label manually to proceed the PR.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tisonkun: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies significant config files which require review from domain experts.

/cc qw4990 bb7133 XuHuaiyu cfzjywxk morgo
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tisonkun
Copy link
Contributor Author

@Mini256 please take a look at this issue. I'm afraid we're blocked for any changes on sessionctx/variable. It is weird that after a config reviewer ( @cfzjywxk ) review or remove the label, it is still there.

@ti-chi-bot
Copy link
Member

@tisonkun: Illegal modification of do-not-merge/blocked-paths label.

In response to removing label named do-not-merge/blocked-paths.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Sep 13, 2021

/merge

@bb7133
Copy link
Member

bb7133 commented Sep 13, 2021

/merge

@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor Author

/run-all-tests

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit c26038b into pingcap:master Sep 13, 2021
@tisonkun tisonkun deleted the issue-27979 branch September 13, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session_test.go has incorrect parallel tests cause data race
6 participants