Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfcs: parser as a go sub-module #28015

Merged
merged 13 commits into from
Sep 26, 2021
Merged

rfcs: parser as a go sub-module #28015

merged 13 commits into from
Sep 26, 2021

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Sep 13, 2021

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Problem Summary: The formal RFC for the draft https://internals.tidb.io/t/topic/385.

Release note 

None

@xhebox
rfcs: parser reorg
45c7f82 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • tisonkun
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2021
@xhebox
rfcs: more descriptions
6679d33 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
rfcs: refine
7c97726 
Signed-off-by: xhe <xw897002528@gmail.com>
kennytm
kennytm reviewed Sep 13, 2021
View reviewed changes
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md

- How about release and versioning?

Since sub-module is merely another module inside another module, we need to release it separately from the main module. That means our release team needs to tag `parser/vX.X.X`, which can be solved by a script: thanks to the identical release cycle/version between parser and tidb.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we could use true semver for the parser sub-module instead of tying with the product release cycle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to leave that as another RFC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it is probably a good idea to keep identical version with tidb, before it becomes a real "standalone" parser.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, IMHO semver is a bigger topic than this, considering all components of TiDB & other components.

docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
xhebox and others added 2 commits September 14, 2021 10:06
@xhebox @kennytm
rfcs: reword
a650822 
Co-authored-by: kennytm <kennytm@gmail.com>
@xhebox
rfcs: transfer issues
57c57a2 
Signed-off-by: xhe <xw897002528@gmail.com>
@tangenta
Copy link
Contributor

tangenta commented Sep 14, 2021 •
edited
Loading

Here is a rough comparison between the master branch of TiDB and parser, FYI:

parser TiDB
cloc (line of code) 68124 869372
commits 750 14571
size of git clone 59MB 181MB

Although the size increasing is much faster in the parser, I don't think git bloating will be a problem.

@xhebox @tangenta
rfcs: retitle
1618d51 
Co-authored-by: tangenta <tangenta@126.com>
tisonkun
tisonkun reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the RFC. Comments inline.

docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Show resolved Hide resolved
docs/design/2021-09-13-parser-as-submodule-of-tidb.md Outdated Show resolved Hide resolved
xhebox and others added 2 commits September 15, 2021 12:44
@xhebox @tisonkun
rfcs: reword from tison
58bd7c5 
Co-authored-by: tison <wander4096@gmail.com>
@xhebox
rfcs: mention about CI
8fa88ac 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox @tangenta
rfcs: reword from tangenta
02d647b 
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2021
@xhebox xhebox added the require-LGT3 Indicates that the PR requires three LGTM. label Sep 22, 2021
@xhebox xhebox mentioned this pull request Sep 22, 2021
Closed
23 tasks
@xhebox
rfcs: link the tracking issue
74ac6d7 
Signed-off-by: xhe <xw897002528@gmail.com>
tisonkun
tisonkun approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the motivation and detailed plan. Release and versioning could be as is for now.

@ti-chi-bot ti-chi-bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 22, 2021
zhouqiang-cl
zhouqiang-cl approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhouqiang-cl
zhouqiang-cl approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2021

It is been 3 days without objection, merge it.
/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74ac6d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@ti-chi-bot ti-chi-bot merged commit db7d910 into pingcap:master Sep 26, 2021
@xhebox xhebox deleted the rework_2 branch September 28, 2021 06:46
@tisonkun tisonkun mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@kennytm kennytm kennytm left review comments

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@tisonkun tisonkun tisonkun approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@bb7133 bb7133 bb7133 approved these changes

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT3 Indicates that the PR requires three LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@xhebox @ti-chi-bot @tangenta @kennytm @bb7133 @AilinKid @wjhuang2016 @tisonkun @zhouqiang-cl