Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: fix data-race bug when alloc task id #28022

Merged
merged 3 commits into from
Sep 22, 2021
Merged

sessionctx: fix data-race bug when alloc task id #28022

merged 3 commits into from
Sep 22, 2021

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Issue Number: close #27952

Problem Summary:
The task id allocator will produce same task id in some cases. When there is a join that cannot be pushed, the build table and probe table will invoke "open" function simultanously. That will cause data race without mutex protection

What is changed and how it works?

Proposal: xxx

the fix is simple,. add lock guard for task id allocator

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

sessionctx: fix data-race bug when alloc task id

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2021
wjhuang2016
wjhuang2016 reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but the test can pass without this PR's modification.

xhebox
xhebox reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a direct test on SessionVars will work better.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2021
@xhebox
Copy link
Contributor

xhebox commented Sep 22, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b56760

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2021
@ti-chi-bot ti-chi-bot merged commit 9a7f572 into pingcap:master Sep 22, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 23, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#28022 to release-5.2
80d749b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 23, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28283

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 23, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#28022 to release-5.0
fc06815 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 23, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28284

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 23, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#28022 to release-5.1
af4023c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 23, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28285

zhouqiang-cl pushed a commit that referenced this pull request Sep 26, 2021
@windtalker
sessionctx: cherry pick #28022 to release-5.0-20210923 (#28343)
30d18b9 
* ddl, executor: fix test race in terror (#25405) (#28198)

* cherry pick #28022 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
windtalker pushed a commit to windtalker/tidb that referenced this pull request Oct 12, 2021
@hanfei1991 @windtalker
sessionctx: fix data-race bug when alloc task id (pingcap#28022)
cc8dbb0
@windtalker windtalker mentioned this pull request Oct 12, 2021
Merged
12 tasks
zhouqiang-cl added a commit that referenced this pull request Oct 12, 2021
@windtalker @hanfei1991 @zhouqiang-cl
sessionctx: fix data-race bug when alloc task id (#28022) (#28742)
eefba66 
Co-authored-by: Han Fei <hanfei19910905@gmail.com>
Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
sessionctx: fix data-race bug when alloc task id (#28022) (#28283)
14c3f82
ti-chi-bot pushed a commit that referenced this pull request Dec 17, 2021
@ti-srebot
sessionctx: fix data-race bug when alloc task id (#28022) (#28284)
aef51c2
ti-chi-bot pushed a commit that referenced this pull request Feb 10, 2022
@ti-srebot
sessionctx: fix data-race bug when alloc task id (#28022) (#28285)
821e50f 
close #27952
@hanfei1991 hanfei1991 deleted the hanfei/ifx-alloc-taskid branch April 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpp task may get the same ID and lead to query failed
6 participants
@hanfei1991 @ti-chi-bot @xhebox @ti-srebot @wjhuang2016 @fzhedu