Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix wrong index hash join when hash col is enum #28032

Merged
merged 5 commits into from
Sep 16, 2021
Merged

executor: fix wrong index hash join when hash col is enum #28032

merged 5 commits into from
Sep 16, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #27893

What is changed and how it works?

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Fix wrong index hash join when hash col is enum.

@lzmhhh123
executor: fix wrong index hash join when hash col is enum
8554ea4 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@qw4990
Copy link
Contributor

qw4990 commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 53ad097

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@ti-chi-bot ti-chi-bot merged commit c103310 into pingcap:master Sep 16, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 16, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#28032 to release-4.0
c592966 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #28079

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 16, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#28032 to release-5.0
9a0f164 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28080

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 16, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#28032 to release-5.1
52ccd82 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28081

@ti-srebot ti-srebot mentioned this pull request Sep 16, 2021
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 16, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#28032 to release-5.2
53d253d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28082

ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
executor: fix wrong index hash join when hash col is enum (#28032) (#…
f005851 
…28081)
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
executor: fix wrong index hash join when hash col is enum (#28032) (#…
3f04cf7 
…28082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inl_merge_join and inl_hash_join have different results
6 participants
@lzmhhh123 @ti-chi-bot @qw4990 @ti-srebot @wjhuang2016 @XuHuaiyu