Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: migrates test-infra to testify for helper_test.go #28132

Merged
merged 6 commits into from
Sep 20, 2021
Merged

types: migrates test-infra to testify for helper_test.go #28132

merged 6 commits into from
Sep 20, 2021

Conversation

dswij
Copy link
Contributor

@dswij dswij commented Sep 17, 2021

Close #28007

What's Changed: Test in format_test.go now uses testify/require instead

None

@dswij
types: migrates test-infra to testify for helper_test.go
6f5e30f 
This commit updates assertion for `helper_test.go` to use `testify`
instead
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2021
@feitian124
Copy link
Contributor

feitian124 commented Sep 17, 2021 •
edited
Loading

LGTM
please make ci happy and check if ci failed due to #25899

@mmyj
Copy link
Member

mmyj commented Sep 17, 2021

/run-check_dev_2

mmyj
mmyj approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2021
@mmyj
Copy link
Member

mmyj commented Sep 19, 2021

/cc @tisonkun

tisonkun
tisonkun approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @dswij !

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2021
@mmyj
Copy link
Member

mmyj commented Sep 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d02464a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2021
@dswij
Copy link
Contributor Author

dswij commented Sep 20, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit c4de011 into pingcap:master Sep 20, 2021
@dswij dswij deleted the helper-test-testify branch September 20, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyj mmyj mmyj approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for helper_test.go
5 participants
@dswij @ti-chi-bot @feitian124 @mmyj @tisonkun