expression: change date add function return type #28133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
|
/run-check_dev_2 |
ti-chi-bot
added
needs-rebase
ti-chi-bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/cc wjhuang2016 |
|
I change branch name to mx/changeDateAddFunctionReturnType, the original pr has closed(#27575) |
|
/cc windtalker |
wjhuang2016
reviewed
Sep 17, 2021
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
|
/run-unit-test |
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6b394825efc6ed636c1c4cb00a652e3a3f98a751 |
ti-chi-bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/run-check_dev_2 |
5 similar comments
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/run-unit-test |
|
/run-mysql-test |
|
/run-unit-test |
|
/run-unit-test |
|
/run-check_dev_2 |
|
/run-unit-test |
wjhuang2016
added
the
needs-cherry-pick-release-5.4
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 31, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
1 task
|
cherry pick to release-5.4 in PR #31239 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
rebelice
pushed a commit
to TiInterstellar/tidb
that referenced
this pull request
Jan 5, 2022
* topsql: make topsql enable only be controlled by pub/sub sink (pingcap#31209) * ddl: support batch create table (pingcap#28763) * executor: fix data race in IndexMergeReaderExec (pingcap#31230) close pingcap#31229 * server: filter the EOF error for normal closed at handshake (pingcap#31081) close pingcap#31063 * expression: change date add function return type (pingcap#28133) close pingcap#27573 * support create interval partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * support create interval partition (support int/timestamp partition key) Signed-off-by: crazycs520 <crazycs520@gmail.com> * parser: support alter table partitions move engine statement Signed-off-by: crazycs520 <crazycs520@gmail.com> * support ddl operation Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager handle job framwork Signed-off-by: crazycs520 <crazycs520@gmail.com> * support auto create interval partition when insert meet no partition suitable error Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix bug Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix cancel job and load old job then continue to do Signed-off-by: crazycs520 <crazycs520@gmail.com> * make partition readonly work(not allow to insert/update/delete) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add begin,end time in tables Signed-off-by: crazycs520 <crazycs520@gmail.com> * tiny fix for auto create interval partition in concurrent case Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * todo: remove flag Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix dumpling Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove data in aws s3 when drop/truncate table/partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * make hello world work Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove debug info Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: guo-shaoge <shaoge1994@163.com> Co-authored-by: knull-cn <hu__haifeng@163.com> Co-authored-by: Meng Xin <tregoldmeng@gmail.com>
1 task
Defined2014
added
the
needs-cherry-pick-release-5.3
1 task
|
In response to a cherrypick label: new pull request created: #38889. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Nov 4, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #27573, close #36394
Problem Summary:
fix the bug that a string like "20129" will not be judged as date type
change date_add and date_sub string_(int/string/real/decimal) function return type to string
What is changed and how it works?
What's Changed:
time.go
expression/builtin_time.go
expression/builtin_time_test.go
expression/builtin_time_vec_generated.go
types/time_test.go
cmd/explaintest/r/tpch.result
How it Works:
if the length of a string with no separator is 5, it will be date type
if use date_add or date_sub string_(int/string/real/decimal) function will return string type
Check List
Tests
Release note