build-in: add sin,cos,tan build-in function #2830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
coocood
reviewed
Mar 15, 2017
expression/builtin_math.go
Outdated
| if err != nil { | ||
| return d, errors.Trace(err) | ||
| } | ||
| d.SetFloat64(math.Cos(x) |
coocood
reviewed
Mar 15, 2017
expression/builtin_math_test.go
Outdated
| } | ||
|
|
||
| for _, test := range testCase { | ||
| fc := funcs[ast.Sqrt] |
There was a problem hiding this comment.
This will get a function of SQRT.
|
Sorry, I copy that from SQRT function, but i forget to run go test. I am
immediately modified.
…On Wed, Mar 15, 2017 at 5:29 PM, Ewan Chou ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In expression/builtin_math_test.go
<#2830 (comment)>:
> +
+func (s *testEvaluatorSuite) TestSin(c *C) {
+ defer testleak.AfterTest(c)()
+
+ testCase := []struct {
+ arg interface{}
+ ret interface{}
+ }{
+ {math.Pi / 2, float64(1)},
+ {math.Pi, float64(1.2246467991473515e-16)},
+ {math.Pi / 3, float64(0.8660254037844387)},
+ {float64(1), float64(0.8414709848078965)},
+ }
+
+ for _, test := range testCase {
+ fc := funcs[ast.Sqrt]
This will get a function of SQRT.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2830 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALfcneVnxrr-cTbRw5G8uLQIhBX86Bucks5rl69tgaJpZM4MdrYn>
.
|
|
Please fix CI. |
|
@willxm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.