builtin: add oct built-in function #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
coocood
reviewed
Mar 15, 2017
plan/typeinferer.go
Outdated
| @@ -404,6 +404,8 @@ func (v *typeInferrer) handleFuncCallExpr(x *ast.FuncCallExpr) { | |||
| tp = types.NewFieldType(mysql.TypeVarString) | |||
| chs = v.defaultCharset | |||
| tp.Flen = 40 | |||
| case ast.Oct: | |||
| tp = types.NewFieldType(mysql.TypeVarString) | |||
coocood
reviewed
Mar 15, 2017
| {"20", "24"}, | ||
| {"100", "144"}, | ||
| {"1024", "2000"}, | ||
| {"2048", "4000"}, |
There was a problem hiding this comment.
Please add cases for different origin types like integer and float.
There was a problem hiding this comment.
Right, add some negative numbers
There was a problem hiding this comment.
Please add a string that is larger than max uint64.
There was a problem hiding this comment.
fixed.
should output the maximum value after exceeding unint64.
|
fixed and please review again. |
coocood
reviewed
Mar 16, 2017
| negative = true | ||
| n = n[1:] | ||
| } | ||
| val, err := strconv.ParseUint(n, 10, 64) |
|
LGTM |
zimulala
reviewed
Mar 17, 2017
plan/typeinferer.go
Outdated
| @@ -406,6 +406,9 @@ func (v *typeInferrer) handleFuncCallExpr(x *ast.FuncCallExpr) { | |||
| tp = types.NewFieldType(mysql.TypeVarString) | |||
| chs = v.defaultCharset | |||
| tp.Flen = 40 | |||
| case ast.Oct: | |||
There was a problem hiding this comment.
You can put this case to line 374.
|
@silenceper |
|
LGTM |
zimulala
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.