*: remove Skip() for some unstable test cases
#28379
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e5359ed45b96847ed3b9de7eea04341a239123eb
|
ti-chi-bot
added
the
status/can-merge
| @@ -8589,9 +8589,6 @@ func (s testSerialSuite) TestExprBlackListForEnum(c *C) { | |||
| } | |||
|
|
|||
| func (s *testResourceTagSuite) TestResourceGroupTag(c *C) { | |||
| if israce.RaceEnabled { | |||
There was a problem hiding this comment.
I think this line cause CI always failed due to unused import.
There was a problem hiding this comment.
[2021-10-02T00:40:06.788Z] executor/executor_test.go:72:2: "github.com/pingcap/tidb/util/israce" imported but not used (typecheck)
[2021-10-02T00:40:06.788Z] "github.com/pingcap/tidb/util/israce"
[2021-10-02T00:40:06.788Z] ^
[2021-10-02T00:40:06.788Z] executor/parallel_apply_test.go:26:2: "github.com/pingcap/tidb/util/israce" imported but not used (typecheck)
[2021-10-02T00:40:06.788Z] "github.com/pingcap/tidb/util/israce"
| @@ -571,10 +571,6 @@ func (s *testSuite) TestApplyCacheRatio(c *C) { | |||
| } | |||
|
|
|||
| func (s *testSuite) TestApplyGoroutinePanic(c *C) { | |||
| if israce.RaceEnabled { | |||
|
@bb7133: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
bb7133
force-pushed
the
bb7133/remove_skip
branch
from
cd37660
to
8d91db4
Compare
ti-chi-bot
removed
the
status/can-merge
|
Merge canceled because a new commit is pushed. |
|
Thanks for your update @bb7133 ! I think you can merge by yourself :) |
|
/run-check_dev_2 |
| @@ -1914,7 +1913,7 @@ func (ts *tidbTestTopSQLSuite) TestTopSQLAgent(c *C) { | |||
| dbt.mustExec("set @@global.tidb_top_sql_max_statement_count=5;") | |||
| setTopSQLReceiverAddress(agentServer.Address()) | |||
| agentServer.WaitCollectCnt(1, time.Second*4) | |||
| checkFn(5) | |||
| checkFn(6) | |||
There was a problem hiding this comment.
@bb7133 it seems this test failed.
[2021-10-07T02:03:08.934Z] tidb_test.go:1916:
[2021-10-07T02:03:08.934Z] checkFn(6)
[2021-10-07T02:03:08.934Z] tidb_test.go:1880:
[2021-10-07T02:03:08.934Z] c.Assert(exist, IsTrue)
[2021-10-07T02:03:08.934Z] ... obtained bool = false
|
@bb7133: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We can try to remove |
|
@bb7133: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Some unstable test cases are skipped by my previous commits like:
The original intention is that those unstable tests can be assigned and fixed eventually. However, most of them are not fixed as planned.
What is changed and how it works?
Bring the skipped unstable test cases back.
Release note