-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the issue that planner may cache invalid plans for joins in some cases (#28432) #28446
planner: fix the issue that planner may cache invalid plans for joins in some cases (#28432) #28446
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@qw4990 you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 305626c
|
/run-mysql-test |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/merge |
/run-mysql-test |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #28432 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28446
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28087, #28162
Problem Summary: planner: fix the issue that planner may cache invalid plans for joins in some cases
What is changed and how it works?
The root cause is that the planner cannot distinguish different parameters when eliminating duplicated DNF conditions.
For example, the DNF
col=1 or col=1
can be converted tocol=1
in this elimination and it is correct.But when values in conditions are parameters instead of constants, the planner may make some wrong eliminating operations since it cannot distinguish different parameters. For example,
col=@a or col=@b
may be converted tocol=@a
.This PR updates the encoding method of expressions to make the planner can distinguish different parameters.
Check List
Tests
Release note