Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Support Reset database placement options by ALTER #28463

Merged
merged 22 commits into from
Oct 18, 2021
Merged

*: Support Reset database placement options by ALTER #28463

merged 22 commits into from
Oct 18, 2021

Conversation

sylzd
Copy link
Contributor

@sylzd sylzd commented Sep 28, 2021 •
edited
Loading

What problem does this PR solve?

Partial close Issue Number: #18203
related to pingcap/parser#1353
fix: #27894

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 28, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sylzd sylzd changed the title *:Support Reset db placement options by ALTER wip:*:Support Reset db placement options by ALTER Sep 28, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2021
@sylzd sylzd changed the title wip:*:Support Reset db placement options by ALTER wip:*:Support Reset placement options by ALTER Oct 9, 2021
@sylzd sylzd mentioned this pull request Oct 17, 2021
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sylzd sylzd changed the title wip:*:Support Reset placement options by ALTER wip:*:Support Reset database placement options by ALTER Oct 17, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Oct 17, 2021

table/partition placement reset should be accomplished after related adding jobs are done.

@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sylzd sylzd changed the title wip:*:Support Reset database placement options by ALTER *:Support Reset database placement options by ALTER Oct 18, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2021
@sylzd sylzd changed the title *:Support Reset database placement options by ALTER *: Support Reset database placement options by ALTER Oct 18, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

xhebox
xhebox reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had proposed to write less code if we assume there is no policy named "default". Then "default" means no policy exclusively, SET DEFAULT is as simple as assign default as the policy name.

Rest LGTM

parser/parser.y Show resolved Hide resolved
parser/parser.y Outdated Show resolved Hide resolved
parser/parser.y Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
@sylzd
Copy link
Contributor Author

sylzd commented Oct 18, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2021
@sylzd sylzd requested review from morgo and xhebox October 18, 2021 09:33
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Oct 18, 2021

/run-check-license

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2021
@morgo
Copy link
Contributor

morgo commented Oct 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae7339f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2021
@ti-chi-bot
Copy link
Member

@sylzd: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sylzd
Copy link
Contributor Author

sylzd commented Oct 18, 2021

/run-check_dev_2

1 similar comment
@sylzd
Copy link
Contributor Author

sylzd commented Oct 18, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 271df16 into pingcap:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@morgo morgo morgo approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sylzd @ti-chi-bot @sre-bot @morgo @xhebox