Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test infra to testify for adpater_test.go #28539

Merged
merged 5 commits into from
Oct 4, 2021
Merged

executor: migrate test infra to testify for adpater_test.go #28539

merged 5 commits into from
Oct 4, 2021

Conversation

subygan
Copy link
Contributor

@subygan subygan commented Oct 2, 2021

What problem does this PR solve?

Issue Number: close #28498

Problem Summary:

Changed test infra to testify from pingcap/check

What's Changed:

How it Works:

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 2, 2021
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 2, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2021
@ti-chi-bot
Copy link
Member

Welcome @suriya-ganesh!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@subygan
Copy link
Contributor Author

subygan commented Oct 2, 2021

/cc @tisonkun

@tisonkun tisonkun changed the title executor: Migrate test infra to testify executor: migrate test infra to testify for adpater_test.go Oct 3, 2021
tisonkun
tisonkun reviewed Oct 3, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Comments inline.

executor/adapter_test.go Outdated Show resolved Hide resolved
executor/adapter_test.go Outdated Show resolved Hide resolved
executor/adapter_test.go Outdated Show resolved Hide resolved
@subygan
Copy link
Contributor Author

subygan commented Oct 3, 2021

idc-jenkins-ci-tidb/check_dev jenkins job has failed. The error is cryptic as well. Can someone suggest me a fix?

@tisonkun
Copy link
Contributor

tisonkun commented Oct 3, 2021

@suriya-ganesh it means gofmt changes the format of the file adapter_test.go.

You can run go fmt ./... from the root path and commit the diff to resolve this problem.

See also https://go.dev/blog/gofmt for more information.

@subygan
Copy link
Contributor Author

subygan commented Oct 4, 2021 •
edited
Loading

@tisonkun please review!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 4, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Oct 4, 2021

/cc @mmyj

@ti-chi-bot ti-chi-bot requested a review from mmyj October 4, 2021 15:35
pingyu
pingyu reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unnecessary blank lines.
Others LGTM.

executor/adapter_test.go Outdated Show resolved Hide resolved
executor/adapter_test.go Outdated Show resolved Hide resolved
mmyj
mmyj approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 4, 2021
@mmyj
Copy link
Member

mmyj commented Oct 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 931fa6e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 4, 2021
@ti-chi-bot ti-chi-bot merged commit 9333c5d into pingcap:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu left review comments

@mmyj mmyj mmyj approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for adapter_test.go
7 participants
@subygan @ti-chi-bot @CLAassistant @tisonkun @mmyj @pingyu @ti-srebot