builtin: add instr built-in function #2857
Conversation
expression/builtin_string.go
Outdated
| return d, errors.Trace(err) | ||
| } | ||
| // INSTR(str, substr) | ||
| if args[0].IsNull() { |
There was a problem hiding this comment.
if args[0].IsNull() || args[1].IsNull(){
return
}
expression/builtin_string_test.go
Outdated
| {[]interface{}{123456, 567}, 0}, | ||
| {[]interface{}{1e10, 1e2}, 1}, | ||
| {[]interface{}{1.234, ".234"}, 2}, | ||
|
|
There was a problem hiding this comment.
Please add a test case like SELECT INSTR('foobarbar', "'');.
expression/builtin_string.go
Outdated
| return d, errors.Trace(err) | ||
| } | ||
| pos := strings.Index(str, substr) + 1 // index starts from 1 | ||
| d.SetInt64(int64(pos)) |
There was a problem hiding this comment.
works wrong with Chinese characters.
Try INSTR("你好世界", "世界")
|
First thanks @spongedu I've just read the INSTR() carefully and realized another mistake except for the problem of ignoring utf8 specified by @spongedu
We need to consider the type of arguments passed to Unfortunately, the implementation of |
expression/builtin_string.go
Outdated
| } | ||
|
|
||
| var caseSensitive bool | ||
| // INSTR performs case **insensitive** search by default |
There was a problem hiding this comment.
add . at the end of this comment.
expression/builtin_string.go
Outdated
|
|
||
| var caseSensitive bool | ||
| // INSTR performs case **insensitive** search by default | ||
| // While at least one argument is binary string we do case sensitive search |
expression/builtin_string.go
Outdated
| caseSensitive = true | ||
| } | ||
|
|
||
| var pos int |
expression/builtin_string.go
Outdated
| return d, nil | ||
| } | ||
|
|
||
| var str string |
|
LGTM |
coocood
added
status/LGT2
Add
INSTR(str, substr)built-in function