Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: limit valid decimal length (#28466) #28648

Merged
merged 2 commits into from
Oct 12, 2021
Merged

expression: limit valid decimal length (#28466) #28648

merged 2 commits into from
Oct 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Oct 8, 2021 •
edited
Loading

cherry-pick #28466 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/28648

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/28648:release-5.1-a18e05d2f7f9

What problem does this PR solve?

Issue Number: close pingcap/tiflash#3091

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@fzhedu @ti-srebot
cherry pick pingcap#28466 to release-5.1
98ec00a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • ichn-hu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 8, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 8, 2021
@ti-srebot ti-srebot added component/expression size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2021
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot ti-srebot added this to the v5.1.2 milestone Oct 8, 2021
@ti-srebot
Copy link
Contributor Author

@fzhedu you're already a collaborator in bot's repo.

LittleFall
LittleFall approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Oct 12, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45d951d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 12, 2021
@ti-chi-bot ti-chi-bot merged commit 6be3ac5 into pingcap:release-5.1 Oct 12, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.1.2, v5.1.4 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@windtalker windtalker Awaiting requested review from windtalker

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@fzhedu fzhedu

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.1-cherry-pick
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @fzhedu @ichn-hu @LittleFall @zhouqiang-cl