-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry&util/memory: bump "gopsutil" version to fix a bug that may cause build failure in macOS #28684
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_dev_2 |
adf1c62
to
f7d4f30
Compare
f7d4f30
to
4910abb
Compare
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_dev_2 |
@zhongzc: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev_2 |
@tangenta @wjhuang2016 PTAL |
/merge |
/merge |
@crazycs520: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@crazycs520: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
gopsutil is also used in https://github.com/pingcap/sysutil /cc @crazycs520 |
@SabaPing: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This problem was fixed by #30523. Closed for now. |
What problem does this PR solve?
Bump gopsutil version to fix a bug that may cause build fail in macOS.
As mentioned in shirou/gopsutil#976,
gopsutil
with old version did not includeTargetConditionals.h
and may cause TiDB build failure in macOS.This PR(shirou/gopsutil#1042) has fixed the issue. And TiDB should catch up this fix.
What is changed and how it works?
Bump
gopsutil
version ingo.mod
andgo.sum
Release note