Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, statistics: fix "data too long for column 'xxx_bound'" when analyze tables with very long strings #28800

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #28793

Several columns in stats-related system tables are not long enough to hold long strings.

What is changed and how it works?

Change these columns from blob to longblob.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix "Data too long for column 'xxx_bound'" error when analyzing a table with strings longer than 65535 bytes.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2021
@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.2

@time-and-fate
Copy link
Member Author

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2021
@qw4990
Copy link
Contributor

qw4990 commented Oct 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 280a452

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2021
@ti-chi-bot ti-chi-bot merged commit de9b5cb into pingcap:master Oct 25, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #29072

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #29073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't analyze columns with string longer than 65535 bytes
6 participants