types, expression: change the result type from float to decimal #28919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminiscent
added
type/bugfix
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
Reminiscent
commented
Oct 18, 2021
Comment on lines
+6302
to
+6305
| tk.MustExec("prepare stmt from 'SELECT UCASE(?) < col_int from t;';") | ||
| tk.MustExec("set @a1 = 'xayh7vrWVNqZtzlJmdJQUwAHnkI8Ec';") | ||
| tk.MustQuery("execute stmt using @a1;").Check(testkit.Rows("<nil>")) | ||
|
|
There was a problem hiding this comment.
The test is unrelated to this method. It's from #13240 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #28858
Problem Summary:
When we compare the
int <cmp> string, the result type is float. It will lose accuracy.What is changed and how it works?
When we compare between int type and string type, the result type should be decimal.
Check List
Tests
Side effects
Documentation
Release note