ddl : support `alter table xx cache` operations #29022

JayLZhou · 2021-10-21T10:05:38Z

What problem does this PR solve?

handle DDL schema changes when a table is set to cachable , we use synatx alter table xx cache to switch a table to cachable
Problem Summary: See Optimizing hotspot small tables #25293

What is changed and how it works?

support switch a table to cachable operation. and do some compatibility check with other feature.
ALTER TABLE t CACHE is a DDL operation. for consistency under distributed conditions. an intermediate Switching state is introduced, the schema change process is similar to the table lock implementation:
Disabled => Switching => Enabled

work

Check List

Tests

Unit test

Release note

None

… into samllhottable-parser

ti-chi-bot · 2021-10-21T10:05:39Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

djshow832
tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

JayLZhou · 2021-10-22T08:45:58Z

./rebuild

tiancaiamao

Rest LGTM

parser/model/ddl.go

parser/model/model.go

JayLZhou · 2021-10-25T02:19:41Z

./rebuild

djshow832 · 2021-10-25T02:51:11Z

ddl/ddl_api.go

@@ -6587,3 +6589,20 @@ func (d *ddl) AlterPlacementPolicy(ctx sessionctx.Context, stmt *ast.AlterPlacem
 	err = d.callHookOnChanged(err)
 	return errors.Trace(err)
 }
+func (d *ddl) AlterTableCache(ctx sessionctx.Context, ti ast.Ident) (err error) {
+	schema, t, err := d.getSchemaAndTableByIdent(ctx, ti)


Check if it is already cached. If it is, we don't even need to add a job.

Is checking the type of the table (is it a view) one of the feature compatibilities you mentioned?

i check if is a already cached in onAlterTableCache function. if needed i can change its position

Typically, we check it twice. One before creating the job and another in executing the job.
Also, please notice the other question I asked above.

djshow832 · 2021-10-25T03:15:01Z

ddl/ddl_api.go

+		SchemaID:   schema.ID,
+		TableID:    t.Meta().ID,


What about SchemaName?

...i not use it. so i am not transfer it

We use it in some places, such as error reporting and show DDL jobs. It's better to follow the convention.

JayLZhou · 2021-10-25T08:25:02Z

@djshow832 please PTAL again

ddl/db_test.go

JayLZhou · 2021-10-25T12:43:54Z

./rebuild

tiancaiamao · 2021-10-25T13:42:25Z

/merge

ti-chi-bot · 2021-10-25T13:42:28Z

This pull request has been accepted and is ready to merge.

Commit hash: f44f76d

tiancaiamao · 2021-10-26T01:07:44Z

close #29085

JayLZhou added 13 commits October 18, 2021 18:43

support sql parser

29b6e03

Merge branch 'master' into samllhottable-parser

4a0631a

support sql parser

aff7123

Merge branch 'samllhottable-parser' of https://github.com/JayL-zxl/tidb…

2b48472

… into samllhottable-parser

new build

f0827a0

Update parser.y

25b27a2

a

ce30e95

Merge remote-tracking branch 'upstream/master' into samllhottable-parser

b078523

Merge branch 'samllhottable-parser' of https://github.com/JayL-zxl/tidb…

a5e96b1

… into samllhottable-parser

modify error and add unit-test

91ff8e7

ddl_support_cache

9d5883b

fix_confilt

da3c94a

add test

c629b3a

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2021

fix_cl

48e2171

tiancaiamao changed the title ~~DDL : support alter table xx cache operations~~ ddl: support alter table xx cache operations Oct 21, 2021

JayLZhou changed the title ~~ddl: support alter table xx cache operations~~ ddl : support alter table xx cache operations Oct 21, 2021

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 21, 2021

modify name

f9b15ee

tiancaiamao reviewed Oct 24, 2021

View reviewed changes

parser/model/ddl.go Outdated Show resolved Hide resolved

parser/model/model.go Outdated Show resolved Hide resolved

keep go name convention

8c4dddb

djshow832 reviewed Oct 25, 2021

View reviewed changes

tiancaiamao mentioned this pull request Oct 25, 2021

Optimizing hotspot small tables #25293

Closed

32 tasks

modidy

0008368

djshow832 reviewed Oct 25, 2021

View reviewed changes

ddl/db_test.go Show resolved Hide resolved

JayLZhou added 2 commits October 25, 2021 20:17

add test

6a8b028

add test

e2dde13

JayLZhou added 4 commits October 25, 2021 21:01

Merge branch 'master' into ddl_cache

c3b7cf8

fix conflict

c7bfa74

fix conflict

6180fea

format

f44f76d

djshow832 approved these changes Oct 25, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2021

tiancaiamao approved these changes Oct 25, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2021

Merge branch 'master' into ddl_cache

145320b

ti-chi-bot merged commit 1777bd0 into pingcap:master Oct 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl : support `alter table xx cache` operations #29022

ddl : support `alter table xx cache` operations #29022

JayLZhou commented Oct 21, 2021 •

edited by tiancaiamao

Loading

ti-chi-bot commented Oct 21, 2021 •

edited

Loading

JayLZhou commented Oct 22, 2021 •

edited

Loading

tiancaiamao left a comment

JayLZhou commented Oct 25, 2021

djshow832 Oct 25, 2021

djshow832 Oct 25, 2021

JayLZhou Oct 25, 2021

djshow832 Oct 25, 2021

djshow832 Oct 25, 2021

JayLZhou Oct 25, 2021

djshow832 Oct 25, 2021

JayLZhou commented Oct 25, 2021

JayLZhou commented Oct 25, 2021

tiancaiamao commented Oct 25, 2021

ti-chi-bot commented Oct 25, 2021

tiancaiamao commented Oct 26, 2021

ddl : support alter table xx cache operations #29022

ddl : support alter table xx cache operations #29022

Conversation

JayLZhou commented Oct 21, 2021 • edited by tiancaiamao Loading

What problem does this PR solve?

What is changed and how it works?

work

Check List

Release note

ti-chi-bot commented Oct 21, 2021 • edited Loading

JayLZhou commented Oct 22, 2021 • edited Loading

tiancaiamao left a comment

Choose a reason for hiding this comment

JayLZhou commented Oct 25, 2021

djshow832 Oct 25, 2021

Choose a reason for hiding this comment

djshow832 Oct 25, 2021

Choose a reason for hiding this comment

JayLZhou Oct 25, 2021

Choose a reason for hiding this comment

djshow832 Oct 25, 2021

Choose a reason for hiding this comment

djshow832 Oct 25, 2021

Choose a reason for hiding this comment

JayLZhou Oct 25, 2021

Choose a reason for hiding this comment

djshow832 Oct 25, 2021

Choose a reason for hiding this comment

JayLZhou commented Oct 25, 2021

JayLZhou commented Oct 25, 2021

tiancaiamao commented Oct 25, 2021

ti-chi-bot commented Oct 25, 2021

tiancaiamao commented Oct 26, 2021

ddl : support `alter table xx cache` operations #29022

ddl : support `alter table xx cache` operations #29022

JayLZhou commented Oct 21, 2021 •

edited by tiancaiamao

Loading

ti-chi-bot commented Oct 21, 2021 •

edited

Loading

JayLZhou commented Oct 22, 2021 •

edited

Loading