Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl : add admin check table / checksum table compatibility for cache table #29082

Closed
wants to merge 1 commit into from
Closed

ddl : add admin check table / checksum table compatibility for cache table #29082

wants to merge 1 commit into from

Conversation

JayLZhou
Copy link
Contributor

What problem does this PR solve?

Issue Number: #25293

Problem Summary:See Optimizing hotspot small tables #25293

What is changed and how it works?

add admin checksum table compatibility and admin check table for cache table
A cache table should forbid admin check / checksum
so the following operations are not allowed
create table t1 (id int)
alter table t1 cache
admin checksum table t1
admin check table t1

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2021
@JayLZhou JayLZhou requested a review from a team as a code owner October 26, 2021 03:13
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2021
@JayLZhou JayLZhou closed this Oct 26, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2021
@JayLZhou JayLZhou deleted the ddl_fc_admincheck_checksum branch October 26, 2021 05:20
@JayLZhou JayLZhou restored the ddl_fc_admincheck_checksum branch October 26, 2021 05:20
@JayLZhou JayLZhou deleted the ddl_fc_admincheck_checksum branch October 26, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants