Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: migrate generated tests to testify #29083

Merged
merged 4 commits into from
Oct 26, 2021
Merged

expression: migrate generated tests to testify #29083

merged 4 commits into from
Oct 26, 2021

Conversation

tisonkun
Copy link
Contributor

This refers #26855 .

Signed-off-by: tison wander4096@gmail.com

Release note

None

/cc @xhebox @mmyj

@tisonkun
expression: migrate generated tests to testify
bdba1b1 
This refers pingcap#26855 .

Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2021
tisonkun
tisonkun commented Oct 25, 2021
View reviewed changes
expression/builtin_vectorized_test.go
@@ -818,6 +818,106 @@ func (s *testEvaluatorSuite) TestFloat32ColVec(c *C) {
c.Assert(col.VecEvalReal(ctx, chk, result), IsNil)
}

func (s *testVectorizeSuite2) TestVecEvalBool(c *C) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from bench_test.go

@tisonkun
Copy link
Contributor Author

will update tracking issue of expression pkg once this PR merged. A bunch of files will be migrated after this PR merged.

@tisonkun
remove createContext...yet
1c9b5da 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

/cc @XuHuaiyu

XuHuaiyu
XuHuaiyu approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
mmyj
mmyj approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2021
@mmyj
Copy link
Member

mmyj commented Oct 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c9b5da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5bb63bd into pingcap:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyj mmyj mmyj approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisonkun @ti-chi-bot @mmyj @XuHuaiyu