mod: add sha2 built-in function #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@zs634134578 Thanks! Please fix ci. |
XuHuaiyu
reviewed
Mar 23, 2017
expression/builtin_encryption.go
Outdated
| if err != nil { | ||
| return d, errors.Trace(err) | ||
| } | ||
| // SHA2 function accepts 2 parameters |
There was a problem hiding this comment.
Length of arguments would be checked in verifyArgs before,
so we don't need to check it here.
expression/builtin_encryption.go
Outdated
| @@ -580,9 +583,58 @@ type builtinSHA2Sig struct { | |||
| baseBuiltinFunc | |||
| } | |||
|
|
|||
| // Supported hash length as the second argument | |||
There was a problem hiding this comment.
Supported hash length of SHA-2 family.
| c.Assert(crypt.IsNull(), IsTrue) | ||
| } | ||
| } | ||
| // Corner case 1: NULL input for sha2 |
There was a problem hiding this comment.
For 0 args, and other incorrect parameter count, MySQL will cause error:
ERROR 1582 (42000): Incorrect parameter count in the call to native function 'sha2'
TiDB will check the count of parameters here
|
LGTM |
|
LGTM |
coocood
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha2 built-in function