Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for hash_table_test.go and grant_test.go #29208

Merged
merged 26 commits into from
Oct 29, 2021
Merged

executor: migrate test-infra to testify for hash_table_test.go and grant_test.go #29208

merged 26 commits into from
Oct 29, 2021

Conversation

YufeiCh
Copy link
Contributor

@YufeiCh YufeiCh commented Oct 28, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #28581
Issue Number: close #28582

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

YufeiCh and others added 17 commits October 26, 2021 16:42
@YufeiCh
executor : migrate test-infra to testify for batch_point_get_test.go
5088674
@YufeiCh
Merge branch 'master' into master
c5cea4f
@YufeiCh
fix check-dev
60dd480
@YufeiCh
Merge branch 'master' of github.com:YufeiCh/tidb
e366aa8
@YufeiCh
Merge branch 'pingcap:master' into master
e485688
@YufeiCh
move testBatchPointGetSuite and newStoreWithBootstrap to executor_tes…
b72b965 
…t.go
@YufeiCh
remove testBatchPointGetSuite from executor_test.go
a36a3fc
@YufeiCh
executor: migrate test-infra to testify for delete_test.go
599fbdb
@YufeiCh
executor : migrate test-infra to testify for index_advise_test.go
63d9880
@YufeiCh
fix for year number and require.EqualError
cee3096
@YufeiCh
Merge branch 'master' into master
36939ee
@YufeiCh
fix for year number and require.EqualError
ecfd490 
fix for gofmt
@YufeiCh
Merge branch 'master' of github.com:YufeiCh/tidb
00b3393
@ti-chi-bot
Merge branch 'master' into master
a850ad9
@YufeiCh
Merge branch 'pingcap:master' into master
e4a9ef5
@YufeiCh
executor: migrate test-infra to testify for hash_table_test.go
2cb2c73
@YufeiCh
Merge branch 'pingcap:master' into master
8afa211
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 28, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@YufeiCh YufeiCh changed the title executor: migrate test-infra to testify for hash_table_test.go executor: migrate test-infra to testify for hash_table_test.go and grant_test.go Oct 28, 2021
@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 28, 2021

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun October 28, 2021 09:09
tisonkun
tisonkun reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Comments inline.

executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 28, 2021

Thank you for your comment. all the subtests of grant_test.go run in parallel now. PTAL, @tisonkun

tisonkun
tisonkun approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox October 28, 2021 10:16
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2021
@xhebox
Copy link
Contributor

xhebox commented Oct 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e4f2e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 29, 2021
@ti-chi-bot
Copy link
Member

@YufeiCh: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 29, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit d69b58f into pingcap:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for hash_table_test.go migrate test-infra to testify for grant_test.go
4 participants
@YufeiCh @ti-chi-bot @xhebox @tisonkun