-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Ensure feature flag support for placement rules #29253
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I am thinking about check it in ddl
, maybe combine with checkAndNormalize
function... It is also strange that we return ddl error in the planner package.
Getting an error from the linter:
I think you will also need to run |
Actually, I started a new pr #29258 and I prefer the new implement 🤣 |
Duplicated with #29258 |
What problem does this PR solve?
Issue Number: close #29088
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note