Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl : ddl forbid partition table switch into cache and add view feature test #29256

Merged
merged 15 commits into from
Nov 1, 2021

Conversation

JayLZhou
Copy link
Contributor

@JayLZhou JayLZhou commented Oct 29, 2021

What problem does this PR solve?

Issue Number: #29318

Problem Summary:

This is a subtask of #25293

What is changed and how it works?

  • Forbid partition table switch cacheablealter partition table cache is not supported
  • Add view feature test, alter view cacheis invalid.
  • Created a file specially used to test the operation of the cache table ddl, and integrated some tests into it.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2021
@JayLZhou
Copy link
Contributor Author

/run-check_dev_2

@JayLZhou
Copy link
Contributor Author

@djshow832 @tisonkun PTAL thks

@JayLZhou
Copy link
Contributor Author

/cc @lcwangchao @tiancaiamao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021
@tiancaiamao tiancaiamao mentioned this pull request Nov 1, 2021
32 tasks
ddl/db_cache_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e733b35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@ti-chi-bot
Copy link
Member

@jayl-zxl: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 01e4bdd into pingcap:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants