Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: grant to non-existent table with at least create privilege #29273

Merged
merged 5 commits into from
Nov 1, 2021
Merged

executor: grant to non-existent table with at least create privilege #29273

merged 5 commits into from
Nov 1, 2021

Conversation

unconsolable
Copy link
Contributor

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #29268

Problem Summary:

What is changed and how it works?

  • When grant to non-existent table, check if the one of the privileges is create or all.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support grant to non-existent table with at least create privilege to keep compatibility with MySQL 8.0

@unconsolable
executor: grant to non-existent table with at least create privilege
96f6d43 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2021
lcwangchao
lcwangchao reviewed Oct 31, 2021
View reviewed changes
executor/grant.go
if err != nil && !terror.ErrorEqual(err, infoschema.ErrTableNotExists) {
return err
// Allow GRANT on non-existent table with at least create privilege, see issue #28533 #29268
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this pr cause some compatibility problems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it won't as it is based on previous PR #28882, and both of them have not delivered to release branch. Or we can wait on @morgo's opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you @unconsolable. It will only cause compatibility issues between from an unreleased version.

AilinKid
AilinKid reviewed Oct 31, 2021
View reviewed changes
executor/grant_test.go Outdated Show resolved Hide resolved
djshow832
djshow832 reviewed Oct 31, 2021
View reviewed changes
executor/grant_test.go Outdated Show resolved Hide resolved
executor/grant_test.go Outdated Show resolved Hide resolved
@unconsolable
executor: check whether privilege takes effect after creation
f855173 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 31, 2021
@morgo
Copy link
Contributor

morgo commented Oct 31, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f855173

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 31, 2021
@ti-chi-bot
Copy link
Member

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor

morgo commented Nov 1, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit a9c249f into pingcap:master Nov 1, 2021
@unconsolable unconsolable deleted the issue-29268 branch November 1, 2021 01:23
@djshow832 djshow832 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@lcwangchao lcwangchao lcwangchao left review comments

@djshow832 djshow832 djshow832 approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grant SELECT and INSERT to non-existent table should report an error
6 participants
@unconsolable @ti-chi-bot @morgo @lcwangchao @AilinKid @djshow832