Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan,table : support write operator for cache table and mock lockwrite state #29444

Merged
merged 47 commits into from
Nov 8, 2021
Merged

plan,table : support write operator for cache table and mock lockwrite state #29444

merged 47 commits into from
Nov 8, 2021

Conversation

JayLZhou
Copy link
Contributor

@JayLZhou JayLZhou commented Nov 4, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
This is a subtask of #25293

What is changed and how it works?

  • suppor write operator for cache table (delete/ add / update)
  • simple test read and wirte operator
  • use a mock stateRemote maintain consistency

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2021
@JayLZhou JayLZhou marked this pull request as draft November 4, 2021 09:01
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2021
@tiancaiamao tiancaiamao linked an issue Nov 4, 2021 that may be closed by this pull request
Support writing to a cached table #29445
Closed
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2021
@tiancaiamao tiancaiamao changed the title dml : dml support write operator for cache table and mock lockwrite state plan,table : support write operator for cache table and mock lockwrite state Nov 5, 2021
tiancaiamao
tiancaiamao reviewed Nov 5, 2021
View reviewed changes
table/tables/cache.go Show resolved Hide resolved
table/tables/cache.go Outdated Show resolved Hide resolved
table/tables/cache.go Outdated
Comment on lines 121 to 122
c.mu.Lock()
defer c.mu.Unlock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If loadDataFromOriginalTable not a method and only depends on sessionctx.Context
c.cacheData is a atomic Value,
c.handle don't write to a internal state,
Then UpdateLockForRead is thread safe and don't need this lock.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do some heavy things under a lock (network here e.g), the lock will block for a long time if conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. i will remove it

table/tables/cache_test.go Outdated Show resolved Hide resolved
table/tables/cache_test.go Outdated Show resolved Hide resolved
table/tables/cache_test.go Outdated Show resolved Hide resolved
table/tables/cache_test.go Outdated Show resolved Hide resolved
table/tables/cache_test.go Outdated Show resolved Hide resolved
table/tables/state_remote.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2021
@tiancaiamao tiancaiamao mentioned this pull request Nov 8, 2021
Closed
32 tasks
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2021
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb65656

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot
Copy link
Member

@jayl-zxl: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JayLZhou
Copy link
Contributor Author

JayLZhou commented Nov 8, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3748f4f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot ti-chi-bot merged commit 9f68c8e into pingcap:master Nov 8, 2021
@JayLZhou JayLZhou deleted the dml_write_and_mock_state branch November 8, 2021 11:32
@JayLZhou JayLZhou mentioned this pull request Nov 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support writing to a cached table
4 participants
@JayLZhou @ti-chi-bot @tiancaiamao @lcwangchao